feat: use medibloc/cosmos-sdk for min_commission_rate + add upgrade handler
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngjoon-lee
requested review from
gyuguen and
cl9200
and removed request for
cl9200 and
gyuguen
youngjoon-lee
changed the title
min_commission_ratemin_commission_rate + add upgrade handler
youngjoon-lee
changed the title
min_commission_rate + add upgrade handlermin_commission_rate + add upgrade handler
youngjoon-lee
changed the title
min_commission_rate + add upgrade handlermin_commission_rate + add upgrade handler
|
We will have to edit CHANGELOG.md later too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #290
Important
This PR is based on the
v2.0branch which currently points to the tagv2.0.2. If this feature is decided to be deployed to mainnet, we must cherry-pick this PR to themasterbranch as well.Changes
*.protoandswagger.jsonwhich is regenerated bymake proto-update-depandmake proto-swagger-gen.min-commission-rategenesis parameter to 3%.min-commission-rate3%.Tests
It was hard to automate tests. I tested the upgrade progress manually.
TODO
https://github.com/medibloc/panacea-core/pull/291/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R59
https://github.com/medibloc/panacea-core/pull/291/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R37