Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host the demo #261

Closed
4 tasks done
remcohaszing opened this issue Jan 13, 2023 · 13 comments
Closed
4 tasks done

Host the demo #261

remcohaszing opened this issue Jan 13, 2023 · 13 comments
Labels
🕸 area/website This affects the website 🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on

Comments

@remcohaszing
Copy link
Member

Initial checklist

Problem

This project has a demo for the Monaco editor integration similar to https://monaco-tailwindcss.js.org, https://monaco-unified.js.org, and https://monaco-yaml.js.org. It would be nice if this demo is hosted somewhere as well.

Solution

The projects mentioned are hosted using Netlify, which is also nice for review environments.

Alternatives

We could also host on Vercel, like https://mdxjs.com. Maybe we want the styling to match https://mdxjs.com and host it on https://monaco.mdxjs.com.

@remcohaszing remcohaszing added 🕸 area/website This affects the website 👋 phase/new Post is being triaged automatically labels Jan 13, 2023
@wooorm
Copy link
Member

wooorm commented Jan 13, 2023

GH pages is very simple and used in a lot of our places too

@remcohaszing
Copy link
Member Author

I do like GH pages, but it doesn’t support PR review environments, right? This is less of an issue compared to my other Monaco editor related projects, as I have a decent idea how to test it now.

@wooorm
Copy link
Member

wooorm commented Feb 3, 2023

Not yet, they’re working on it though. Might never happen but it’s a bit promising.
Anyway, do we really need that? Presumably the tests check much more than a demo

@remcohaszing
Copy link
Member Author

The GitHub action is ready.

On https://github.com/mdx-js/vscode-mdx/settings/pages, Source needs to be set to GitHub Actions and a custom domain needs to be configured. I don’t have access though.

Personally I’m in favor of using https://monaco.mdxjs.com.

@ChristianMurphy
Copy link
Member

On https://github.com/mdx-js/vscode-mdx/settings/pages, Source needs to be set to GitHub Actions

Done

custom domain needs to be configured. I don’t have access though.

This part I don't have access to either

@remcohaszing
Copy link
Member Author

Thanks! The build is now succesful, so that’s good to know.

https://mdx-js.github.io/vscode-mdx/

@tippfelher
Copy link

image

@remcohaszing remcohaszing added the 🙅 no/wontfix This is not (enough of) an issue for this project label Oct 24, 2023
@github-actions

This comment was marked as resolved.

@remcohaszing
Copy link
Member Author

The Monaco integration was removed in favor of Volar. Use @volar/monaco if you would like to use this with Monaco editor.

@remcohaszing remcohaszing closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
@github-actions

This comment was marked as resolved.

@remcohaszing remcohaszing added 👎 phase/no Post cannot or will not be acted on and removed 👋 phase/new Post is being triaged automatically labels Oct 24, 2023
@CapitaineToinon
Copy link

Hey, sorry to revive an old thread but are there examples around on using mdx with monaco via volar, if that's how we're supposed to do it? I've been fiddling around but I'm pretty lost to be honest. I'm trying to setup use monaco to edit MDX stored in my database and I believe this package is where I should be looking at.

@remcohaszing
Copy link
Member Author

You can have a look at @volar/monaco

You should be able to add the language plugin from @mdx-js/language-service for MDX language support and the service plugin for extra functionality, such as syntax error reporting.

@websiddu
Copy link

A demo with @volar/monaco and @mdx-js/language-service integration would be greatly apricated and it will be super useful to show case all the featured of mdx-analyzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕸 area/website This affects the website 🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

6 participants