Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Temporal data #24005

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Update Temporal data #24005

merged 1 commit into from
Aug 16, 2024

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jul 31, 2024

This PR updates Temporal compat data.

  • Remove descriptions as it is more conventional to not have them
  • Update constructor descriptions to match BCD conventions
  • Fix some typos in spec_url fragments
  • Rename calendar properties to calendarId
  • Rename timezone properties to timezoneId
  • Remove properties per Normative: Partial stack of removals tc39/proposal-temporal#2895
  • Add yearOfWeek properties
  • Remove TimeZone.p.getNextTransition and TimeZone.p.getPreviousTransition
  • Add ZonedDateTime.p.getTimeZoneTransition

(Looks more removals will come: tc39/proposal-temporal#2925 but thanks to the spec_url validation I'm doing in #23958 we'll be able to keep track of this going forward.)

@github-actions github-actions bot added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jul 31, 2024
@Elchi3 Elchi3 mentioned this pull request Jul 31, 2024
Merged
@Elchi3 Elchi3 requested a review from queengooborg August 12, 2024 09:17
queengooborg
queengooborg approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of different changes so I did a quick overview -- LGTM!

@queengooborg queengooborg merged commit 9595829 into mdn:main Aug 16, 2024
5 checks passed
@Elchi3 Elchi3 deleted the temporal-update branch August 17, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elchi3 @queengooborg