Skip to content

Commit

Permalink
http2: make compat writeHead not crash if the stream is destroyed
Browse files Browse the repository at this point in the history
  • Loading branch information
mcollina committed Nov 29, 2018
1 parent 8ce0d4f commit 69e283e
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/internal/http2/compat.js
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,11 @@ class Http2ServerResponse extends Stream {
if (this[kStream].headersSent)
throw new ERR_HTTP2_HEADERS_SENT();

// If the stream is destroyed, we return false,
// like require('http').
if (this.stream.destroyed)
return false;

if (typeof statusMessage === 'string')
statusMessageWarn();

Expand Down
29 changes: 29 additions & 0 deletions test/parallel/test-http2-compat-write-head-destroyed.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');

// Check that writeHead, write and end do not crash in compatibikity mode

const server = http2.createServer(common.mustCall((req, res) => {
// destroy the stream first
req.stream.destroy();

res.writeHead(200);
res.write('hello ');
res.end('world');
}));

server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);

const req = client.request();
req.on('response', common.mustNotCall());
req.on('close', common.mustCall((arg) => {
client.close();
server.close();
}));
req.resume();
}));

0 comments on commit 69e283e

Please sign in to comment.