-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Moved "Return to Regular Route" into root directions list #2521
Conversation
Coverage of commit
|
Coverage of commit
|
Coverage of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments but otherwise this looks good!
didn't mean to approve just yet 😬 and I would like those comments resolved before merging
Co-authored-by: Kayla Firestack <[email protected]>
I think it looks good - I made a few non-blocking nits, but the only reason I'm not approving is so that I don't scoop Kayla's review. |
Coverage of commit
|
Co-authored-by: Kayla Firestack <[email protected]>
Co-authored-by: Josh Larson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @hannahpurcell!!
The little things I like about this approach is that
diversionPage
now sufficiently covers the check "was 'Return to Regular Route' added to the directions sequence"Also included, updating the Storybook story for this!