Prepare upgrade to Django 4.2 #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated settings from the default project
These are the straightforward ones
This will be needed for the new notifications_api_common library
Upgrade is pretty straightforward. Followed documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
==========================================
- Coverage 94.90% 94.84% -0.06%
==========================================
Files 133 135 +2
Lines 4628 4657 +29
==========================================
+ Hits 4392 4417 +25
- Misses 236 240 +4 ☔ View full report in Codecov by Sentry. |
By updating a couple libraries and removing a deprecated setting
|
Waiting on a new |
This was referenced Mar 1, 2024
annashamray
reviewed
Mar 4, 2024
annashamray
requested changes
Mar 14, 2024
There was a problem hiding this comment.
OAS schemas are not generated anymore. Requesting http://127.0.0.1:8000/api/v2/schema/ fails with error:
AttributeError: module 'rest_framework.serializers' has no attribute 'NullBooleanField'
I think it's because drf-spectacular and rest_framework have conflict versions
Could you please fix it and add a regression test (requesting "v2:schema" returns 200)?
Latest version without too much breaking changes Fix `AutoSchema` subclass Regenerate schemas Add regression test
annashamray
requested changes
Mar 14, 2024
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.