Feat/tests improvements #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endencies versions
marek-szydlow
requested review from
patryk-grudzien-keen and
maciej-nedza
and removed request for
SebastianMiklaszewskiBldr
patryk-grudzien-keen
requested changes
Feb 7, 2024
requirements.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| apimatic-core~=0.2.0 | |||
| apimatic-core>=0.2.8 | |||
There was a problem hiding this comment.
This file is not supposed to be modified because, on each SDK regeneration, it'll be overridden by APIMatic.
| @@ -1,6 +0,0 @@ | |||
| auth=$(echo "$BASIC_AUTH_USERNAME":"$BASIC_AUTH_PASSWORD" | base64) | |||
|
|
|||
| curl --request POST \ | |||
There was a problem hiding this comment.
Because this script won't be needed anymore, please delete it also from the .codegenignore file.
|
|
||
| yield client | ||
|
|
||
| client.sites.clear_site() |
There was a problem hiding this comment.
Won't it be invoked twice when requesting client in two consecutive tests?
| from advancedbilling.models.subscription import Subscription | ||
|
|
||
|
|
||
| class InvoiceAssertCases: |
There was a problem hiding this comment.
All these classes live in the data module and in general, provide only the pure dictionaries so, I'd think about different names instead of assert because there are no asserts there.
| @@ -0,0 +1,16 @@ | |||
| __all__ = [ | |||
There was a problem hiding this comment.
Is this needed for subsequent cases to be properly loaded?
michalpierog
approved these changes
Feb 7, 2024
patryk-grudzien-keen
force-pushed
the
feat/tests-improvements
branch
from
bfec828 to
c8b6eef
Compare
patryk-grudzien-keen
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.