feat(python-sdk): MAX-28 - test preview allocations - happy path #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "unit_name": "Component", | ||
| "unit_price": "1.0", | ||
| "allow_fractional_quantities": True, | ||
| "quantity": 1, |
There was a problem hiding this comment.
there's no such property for quantity_based_component, we specify quantity during the allocation.
There was a problem hiding this comment.
removed
|
Some general question: don't we need any cleanup/teardown method for tests? Is it safe to run those tests multiple times? Is it already implemented somewhere? |
SebastianMiklaszewskiBldr
force-pushed
the
feat/MAX-18-2
branch
from
471f533 to
a3fc758
Compare
|
@michalpierog regarding cleanup. Currently I clean at the end of the tests everything what I can. Mostly subscriptions and customers. Later I want to add similar solution like in php-sdk with sh script which I will run on CI to cleanup the site before and after tests |
SebastianMiklaszewskiBldr
force-pushed
the
feat/MAX-28
branch
2 times, most recently
from
11536ef to
ed80e70
Compare
SebastianMiklaszewskiBldr
force-pushed
the
feat/MAX-28
branch
from
ed80e70 to
c1a63b7
Compare
michalpierog
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.