[DE-606] Currency prices review suggestions

maxio-com · Nov 19, 2024 · 4ccae25 · 4ccae25
1 parent 937d513
commit 4ccae25
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.../advancedbilling/controllers/components/ComponentsControllerCreateCurrencyPricesTest.java b/.../advancedbilling/controllers/components/ComponentsControllerCreateCurrencyPricesTest.java
@@ -50,7 +50,7 @@ void shouldCreateComponentPricePointCurrencyPrices() throws IOException, ApiExce
                                 .build(),
                         new CreateCurrencyPrice.Builder()
                                 .currency("EUR")
-                                .price(11d)
+                                .price(11.0)
                                 .priceId(price2Id)
                                 .build()
                 )

diff --git a/.../advancedbilling/controllers/components/ComponentsControllerUpdateCurrencyPricesTest.java b/.../advancedbilling/controllers/components/ComponentsControllerUpdateCurrencyPricesTest.java
@@ -27,7 +27,7 @@
 public class ComponentsControllerUpdateCurrencyPricesTest extends ComponentsControllerTestBase {
 
     @Test
-    void shouldCreateComponentPricePointCurrencyPrices() throws IOException, ApiException {
+    void shouldUpdateComponentPricePointCurrencyPrices() throws IOException, ApiException {
         // given
         Component component = createQuantityBasedComponent();
         ComponentPricePoint componentPricePoint = TEST_SETUP.createComponentPricePoint(component.getId());
@@ -43,14 +43,14 @@ void shouldCreateComponentPricePointCurrencyPrices() throws IOException, ApiExce
                                 .build(),
                         new CreateCurrencyPrice.Builder()
                                 .currency("EUR")
-                                .price(11d)
+                                .price(11.0)
                                 .priceId(price2UsdId)
                                 .build()
                 )
         );
 
         // create new currency prices
-         COMPONENTS__PRICE_POINT_CONTROLLER
+        COMPONENTS__PRICE_POINT_CONTROLLER
                 .createCurrencyPrices(componentPricePoint.getId(), createCurrencyPricesRequest);
 
         // get ids of created currency prices
@@ -84,7 +84,7 @@ void shouldCreateComponentPricePointCurrencyPrices() throws IOException, ApiExce
                 Collectors.toMap(ComponentCurrencyPrice::getId, Function.identity())
         );
 
-        for (int i=0; i<currencyPricesWithIds.size(); i++) {
+        for (int i = 0; i < currencyPricesWithIds.size(); i++) {
             ComponentCurrencyPrice oldCurrencyPrice = currencyPricesWithIds.get(i);
             UpdateCurrencyPrice updatePriceRequest = updateCurrencyPrices.get(i);
             ComponentCurrencyPrice updatedPrice = idsToPrice.get(updatePriceRequest.getId());