Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option #710

Merged
merged 4 commits into from
Apr 2, 2019
Merged

Add configuration option #710

merged 4 commits into from
Apr 2, 2019

Conversation

julianoes
Copy link
Collaborator

This adds a configuration option in order to set the system and component ID of the SDK, as well as correctly set the MAV_TYPE.

FYI @bkueng @cmic0.

JonasVautherin
JonasVautherin previously approved these changes Mar 27, 2019
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely sure what I should do with the FIXMEs, but... let's say it's good enough for now 😅.

This adds a configuration option in order to set the system and
component ID of the SDK, as well as correctly set the MAV_TYPE.
@RomanBapst
Copy link

@julianoes @JonasVautherin Is this good to go?

@julianoes
Copy link
Collaborator Author

Needs testing by @cmic0.

@RomanBapst
Copy link

@julianoes I did test it and it worked. According to @cmic0 he still need to do changes on the firmware side when running avoidance.

@julianoes
Copy link
Collaborator Author

@RomanBapst great thanks.

@julianoes julianoes merged commit 5f16583 into develop Apr 2, 2019
@julianoes julianoes deleted the add-configuration branch April 2, 2019 15:10
@RomanBapst
Copy link

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants