Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: fix bug in STRING REPLACE #671

Merged
merged 1 commit into from
Feb 15, 2019
Merged

cmake: fix bug in STRING REPLACE #671

merged 1 commit into from
Feb 15, 2019

Conversation

JonasVautherin
Copy link
Collaborator

The last argument of STRING REPLACE, which is a variable, has to be
inside double quotes otherwise it may be misinterpreted.

@JonasVautherin
cmake: fix bug in STRING REPLACE
164992b 
The last argument of STRING REPLACE, which is a variable, has to be
inside double quotes otherwise it may be misinterpreted.
@JonasVautherin JonasVautherin self-assigned this Feb 14, 2019
julianoes
julianoes approved these changes Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't know.

@JonasVautherin
Copy link
Collaborator Author

Well, if VERSION_STR's value is "0.14.0", that's fine, but if it's "something with spaces", suddenly the CMAKE command ends up having 3 parameters instead of one ([something, with, spaces] instead of "something with spaces").

@JonasVautherin JonasVautherin merged commit c5ca314 into develop Feb 15, 2019
@JonasVautherin JonasVautherin deleted the fix-cmake branch February 15, 2019 08:39
@julianoes
Copy link
Collaborator

Right ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

Assignees

@JonasVautherin JonasVautherin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonasVautherin @julianoes