Fix mission gRPC server crash #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If two subsequent mission progress are published at (almost) the same time on different threads (from the thread pool) we experienced undefined behaviour. This lock as proven to protect us from that.
This way we allow the user of the library to delete itself by doing `mission->subscribe_progress(nullptr)`.
This caused a race condition where we wanted to inform the user that current is now 0 and at the same time we also received an ACK/ACCEPTED and reported -1. By removing these lines -1 we should avoid this race, and also avoid having confusing -1 progress reports to the user.
JonasVautherin
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix mavlink/MAVSDK-Python#46 as well as a couple of other potential mission crashes.