Install plugin headers in hierarchy #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't install the plugins in a flat hierarchy but into plugins/pluginname. Then we will include the plugins using: `#include <dronecode_sdk/plugins/pluginname/pluginname.h`
The public headers need to use the public dronecode_sdk includes.
The header files are no longer in a flat hierarchy.
|
Seems like it's failing on every single platform our CI runs. Does it build on your machine? :-) |
|
Hm, I should probably try to build that again without having the headers already installed 😄. |
This is required so that includes work properly for the public header files needed by the plugins. The plugins can now include the plugin_base.h like this: `#include <dronecode_sdk/plugin_base.h>`
This should fix the shallow git submodule clone in appveyor.
This should fixe the package generation: - The library `tinyxml2` is no longer a dependency. - We gather the files to be installed automatically from the install directory instead of manually specifying them. - The install directory should now be correctly in /usr/lib and /usr/include. - The build ID files are omitted on Fedora.
JonasVautherin
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #637.