calibration: return only one struct (and the result) #560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the Rx language bindings, we cannot have more than one return type (that is, one
Result
that says when there is an error and when the stream completes, and one actual struct containing data). This has to be reflected in the C++ API if we want to auto-generate those headers, too.Moreover, some languages don't have the notion of
NaN
and default to0
(which is an issue for e.g. aprogress
). For this reason, the resulting struct has booleans to explicitly say if a value is defined or not.Finally, I tried to remove some code duplication (see here). It should behave the same in my understanding.