Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibration: return only one struct (and the result) #560

Merged
merged 2 commits into from
Oct 1, 2018

Conversation

JonasVautherin
Copy link
Collaborator

Because of the Rx language bindings, we cannot have more than one return type (that is, one Result that says when there is an error and when the stream completes, and one actual struct containing data). This has to be reflected in the C++ API if we want to auto-generate those headers, too.

Moreover, some languages don't have the notion of NaN and default to 0 (which is an issue for e.g. a progress). For this reason, the resulting struct has booleans to explicitly say if a value is defined or not.

Finally, I tried to remove some code duplication (see here). It should behave the same in my understanding.

@JonasVautherin JonasVautherin force-pushed the calibration-callback-one-result branch 6 times, most recently from f6e9b9d to d41b183 Compare September 30, 2018 22:48
@JonasVautherin JonasVautherin force-pushed the calibration-callback-one-result branch from d41b183 to 14f330d Compare September 30, 2018 22:51
@JonasVautherin JonasVautherin force-pushed the calibration-callback-one-result branch from 14f330d to 6508259 Compare September 30, 2018 23:00
@julianoes julianoes merged commit 704ab33 into develop Oct 1, 2018
@julianoes julianoes deleted the calibration-callback-one-result branch October 1, 2018 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants