core: disable fallback to system ID for now #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fallback to system ID causes problems on systems with multiple components that might answer but do not actually mean that a vehicle is connected. For instance the remote controller might also send heartbeats and trigger a discovery event when really the drone is not discovered (yet). In the future we might add an option for UUID vs. system ID but for now this should resolve the issues described.
JonasVautherin
force-pushed
the
fix-discovery
branch
from
50beb8d to
f20d5a9
Compare
JonasVautherin
approved these changes
Aug 30, 2018
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
core: disable fallback to system ID for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback to system ID causes problems on systems with multiple
components that might answer but do not actually mean that a vehicle is
connected. For instance the remote controller might also send heartbeats
and trigger a discovery event when really the drone is not discovered
(yet).
In the future we might add an option for UUID vs. system ID but for now
this should resolve the issues described.