core: bugfix for clearing message handlers #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bugfix for a bug discovered by Jy.wang. What happened is that when one plugin would want to clear all its message handlers, the whole mavlink hander table gets cleared and all other plugins and the core lose their handlers as well. This bug only manifests itself in practice if you actually destroy a plugin before others or the core which happens rarely since mostly everything together is destroyed at the very end.
JonasVautherin
approved these changes
Jul 24, 2018
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
core: bugfix for clearing message handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for a bug discovered by Jy.wang.
What happened is that when one plugin would want to clear all its
message handlers, the whole mavlink hander table gets cleared and all
other plugins and the core lose their handlers as well.
This bug only manifests itself in practice if you actually destroy a
plugin before others or the core which happens rarely since mostly
everything together is destroyed at the very end.
Fixes #464.