Allow DroneCore to be added to built by a parent cmake project #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
changed the title
julianoes
requested changes
Jun 6, 2018
core/CMakeLists.txt
Outdated
| ${PROJECT_SOURCE_DIR}/core/global_include_test.cpp | ||
| ${PROJECT_SOURCE_DIR}/core/mavlink_channels_test.cpp | ||
| ${PROJECT_SOURCE_DIR}/core/unittests_main.cpp | ||
| # TODO: add this again |
There was a problem hiding this comment.
Please delete the trailing white space.
plugins/mission/CMakeLists.txt
Outdated
| ${CMAKE_SOURCE_DIR}/core | ||
| SYSTEM ${CMAKE_SOURCE_DIR}/third_party/include | ||
| #${CMAKE_CURRENT_SOURCE_DIR}/core | ||
| #SYSTEM ${CMAKE_CURRENT_SOURCE_DIR}/third_party/include |
There was a problem hiding this comment.
Fix the accidental # changes here.
Stifael
changed the title
JonasVautherin
approved these changes
Jun 6, 2018
|
Thanks! Why is it a [WIP]? Can't we merge it? |
Stifael
changed the title
Additional missing replacements. Should be ok now |
julianoes
approved these changes
Jun 6, 2018
|
@JonasVautherin oh looks like Jenkins forgot how to do clang-format. |
|
Waiting with merging until we figure the Jenkinsbuild out in #420. |
|
@Stifael please rebase, CI should be fixed. |
… PROJECT_SOURCE_DIR
note: third_party/include does not exist
Stifael
force-pushed
the
cmake_directory_fix
branch
from
08a953a to
649c394
Compare
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
Allow DroneCore to be added to built by a parent cmake project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows DroneCore to be added to any cmake project just by doing: