fly_qgc_mission: link to json11 #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to link to libjson11 as well because libdronecore_mission.so doesn't include it.
|
Is json present by default on machines or will library need to be installed (so it can be linked). Or to put it another way, is there an extra step that needs to be added to run this example? |
|
Isn't |
|
@JonasVautherin this fix is for macOS. |
|
Are you sure you updated your submodules? It should be in |
Let me check. |
This reverts commit e9573a6.
This fixes the issue where json11 symbols were not included in the .a plugin library files. When the plugins are compiled as dynamic libs, the needed symbols from libjson11.a are included. This means that the symbols will still be missing for Android and iOS, however, the functionality is currently not needed there.
JonasVautherin
approved these changes
May 17, 2018
We should not need to link to json11 in the example because the symbols are already included in dronecore_mission.so.
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
fly_qgc_mission: link to json11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to link to libjson11 as well because libdronecore_mission.so doesn't include it.
@JonasVautherin any better idea? Or should we include json11 inside
libdronecore.alike tinyxml2 to prevent this?Fixes #381.