Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2 only] core: use http instead of https #2471

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

julianoes
Copy link
Collaborator

With v2 we don't have https support in cURL that we compile, so we have to try http instead of https.

In order to avoid dependency churn on v2, I suggest to just use this hack instead of #2460.

@rayw-dronesense would this work for you?

With v2 we don't have https support in cURL that we compile, so we have
to try http instead of https.
Copy link

sonarcloud bot commented Dec 12, 2024

@julianoes julianoes changed the title core: use http instead of https [v2 only] core: use http instead of https Dec 12, 2024
@julianoes
Copy link
Collaborator Author

Merging, to get this into the latest release.

@julianoes julianoes merged commit a964028 into v2 Dec 12, 2024
33 checks passed
@julianoes julianoes deleted the pr-v2-https-workaround branch December 12, 2024 20:26
@rayw-dronesense
Copy link
Contributor

@julianoes - Nope:

2024-12-13 12:05:01.388 13936-14229 Mavsdk                  com.dronesense.pilot.blue            I  Download file: https://github.com/Gremsy/Vio-Camera-Definition/releases/download/v2.0.3/vio_camera_f1_def.xml using cURL...
2024-12-13 12:05:01.388 13936-14229 Mavsdk                  com.dronesense.pilot.blue            I  Downloading camera definition from: https://github.com/Gremsy/Vio-Camera-Definition/releases/download/v2.0.3/vio_camera_f1_def.xml
2024-12-13 12:05:01.388 13936-14229 Mavsdk                  com.dronesense.pilot.blue            W  Downloading over http instead of https
2024-12-13 12:05:01.427 13936-14065 Mavsdk                  com.dronesense.pilot.blue            W  Received ack for not-existing command: 521! Ignoring...
2024-12-13 12:05:01.548 13936-14229 Mavsdk                  com.dronesense.pilot.blue            I  Downloaded file, result Success
2024-12-13 12:05:01.548 13936-14229 Mavsdk                  com.dronesense.pilot.blue            D  Successfully loaded camera definition
2024-12-13 12:05:01.548 13936-14229 Mavsdk                  com.dronesense.pilot.blue            E  tinyxml2::Parse failed: Error=XML_ERROR_EMPTY_DOCUMENT ErrorID=13 (0xd) Line number=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants