Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes MAVSDK-Java#155 camera::possibleSettingOptions crashes as a result of erroneous string format #2451

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

rayw-dronesense
Copy link
Contributor

Corrects the conversion to numeric string representation

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 wouldn't that then not require the whole stringstream logic at all and you could just directly set the option_id?

option.option_id = value.get_string()

I'm not sure whether we're missing something here.

@rayw-dronesense
Copy link
Contributor Author

🤔 wouldn't that then not require the whole stringstream logic at all and you could just directly set the option_id?

option.option_id = value.get_string()

I'm not sure whether we're missing something here.

You're right, it's not needed anymore. I was originally basing the fix on existing logic.

Copy link

sonarcloud bot commented Nov 25, 2024

@julianoes
Copy link
Collaborator

I guess it doesn't break any tests, so I'm going to trust you that this is right.

@julianoes julianoes merged commit 7f2a9dd into mavlink:v2.12 Nov 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants