Improve Fly mission example #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2018 18:26
json11 is a tiny JSON library for C++11. We require it for parsing JSON files.
Example extracts waypoint missions from QGC plan and does upload, start, stop of those missions.
|
I strongly feel we can have add public method in Mission plugin which will do everything for the application. |
julianoes
reviewed
Jan 19, 2018
| } | ||
|
|
||
| // This looks bit complicated at app users. | ||
| // Should we handle them in plugin ? |
There was a problem hiding this comment.
Yes, we should think of an import/export function inside the plugin.
|
So just FYI this has been superseded by #235 , which adds the import/export function from a QGC plan within the module. |
|
@hamishwillee yes. this PR mostly going to become obsolete when #235 is merged. However, until that PR is merged this one may be used by testing team (#233); hence this is kept open. |
dlech
pushed a commit
to dlech/MAVSDK
that referenced
this pull request
Jan 14, 2022
Small telemetry improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to improve Fly mission example based on issue #121.
Highlights:
Adds json11 as a submodule for parsing JSON files
Example now handles waypoint missions fed from QGC plan (via command line arguments)
Open question: I feel the application code has more job to do. Can we provide an interface at Mission plugin ?