Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc:Update python client for dynamic plugin loading #174

Merged
merged 1 commit into from
Nov 28, 2017
Merged

grpc:Update python client for dynamic plugin loading #174

merged 1 commit into from
Nov 28, 2017

Conversation

Rjasuja
Copy link
Contributor

@Rjasuja Rjasuja commented Nov 24, 2017

Update python examples

@Rjasuja
Copy link
Contributor Author

Rjasuja commented Nov 24, 2017

For async_client.py, thread for telemetry exits with Status Code as CANCELLED.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.476% when pulling 354289d on Rjasuja:upstream1 into 02a9b48 on dronecore:develop.

@JonasVautherin
Copy link
Collaborator

JonasVautherin commented Nov 27, 2017 •
edited
Loading

@Rjasuja, @avinash-palleti: How do you test this? When using this PR together with #173, and running both dronecore_server and either async_client.py or sync_client.py, I get:

grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with (StatusCode.UNAVAILABLE, Endpoint read failed)>

And a segmentation fault on the server side.

JonasVautherin
JonasVautherin approved these changes Nov 28, 2017
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My segmentation fault was due to my manually-compiled gRPC and/or Protobuf libraries. Using the system libraries, it is working!

grpc/python_client/CMakeLists.txt
@@ -5,6 +5,7 @@ include(FindPythonInterp REQUIRED)
add_custom_target(pydronecore ALL)

set(plugins_dir ${CMAKE_SOURCE_DIR}/grpc/server/plugins)
set(plugins_list action mission telemetry)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the way it is done in #179: file(STRINGS ../proto/plugins.conf plugins_list), so that it is not hard-coded.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I will change it in #179.

@julianoes
Copy link
Collaborator

Thanks @Rjasuja and sorry for not properly looking at your PR and duplicating the work. That was stupid from my side 😅.

@julianoes julianoes merged commit 440f6e2 into mavlink:develop Nov 28, 2017
@julianoes julianoes mentioned this pull request Nov 28, 2017
Merged
dlech pushed a commit to dlech/MAVSDK that referenced this pull request Jan 14, 2022
@JonasVautherin
Merge pull request mavlink#174 from amadoruavs/statustext
8b7dc4e 
Add all MAVLink STATUSTEXT severity enum values to StatusTextType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes left review comments

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rjasuja @coveralls @JonasVautherin @julianoes