Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack 5 compatibility with MDS site #381

Closed
wants to merge 34 commits into from
Closed

Webpack 5 compatibility with MDS site #381

wants to merge 34 commits into from

Conversation

juanca
Copy link
Contributor

@juanca juanca commented Sep 21, 2021 •
edited
Loading

Motivation

In order to get bigmaven working with Webpack 5, we need our MDS sites to be Webpack 5 compatible.

Acceptance Criteria

  • MDS site loads
  • MDS site looks good
  • MDS site components work as expected

PR upkeep checklist

juanca added 26 commits September 21, 2021 11:20
@juanca
dep(react-styleguidist): use version with Webpack 5 support
3188894
@juanca
dep(babel-loader): latest major version 8
2fabdfb
@juanca
dep(css-loader): latest major version 2
67e4ad0
@juanca
dep(css-loader): latest major version 3
bd86b3c
@juanca
dep(postcss-loader): latest major version 4
6c7bbf6
@juanca
dep(style-loader): latest major version 1
b9051a9
@juanca
dep(style-loader): latest major version 2
ad2fb97
@juanca
dep(css-loader): latest major version 4
2c7aaf8
@juanca
dep(css-loader): latest major version 5
363d191
@juanca
dep(url-loader): latest major version 1
6dacde6
@juanca
dep(url-loader): latest major version 2
b96111b
@juanca
dep(url-loader): latest major version 3
5a273f1
@juanca
dep(url-loader): latest major version 4
94f66ba
@juanca
dep(svgo-loader): latest major version 2
0f24507
@juanca
dep(svgo-loader): latest major version 3
3328237
@juanca
dep(svg-sprite-loader): latest major version 3
b35d777
@juanca
dep(svg-sprite-loader): latest major version 4
0067cba
@juanca
dep(svg-sprite-loader): latest major version 5
94bcd30
@juanca
dep(svg-sprite-loader): latest major version 6
98156a7
@juanca
refactor(webpack): remove redundant empty options (was bug, now fixed…
9efd90d 
… in some upgrade)
@juanca
dep(webpack): latest major version 5
48e82b9 
fix(webpack): ensure rules are iterable
fix(site): ensure icons page does not use NodeJS#path
@juanca
dep(style-loader): latest major version 3
9d61e09
@juanca
dep(css-loader): latest major version 6
649e9af
@juanca
dep(postcss-loader): latest major version 5
768ef5e
@juanca
dep(postcss-loader): latest major version 6
4e6ac12
@juanca
dep(url-loader): remove unused loader -- was used for Hero images but…
c5e145f 
… those are deprecated for simplicity
@juanca juanca added site refactor No change in behavior--just in design or readability labels Sep 21, 2021
@juanca juanca self-assigned this Sep 21, 2021
@juanca juanca requested a review from Bloodyaugust September 21, 2021 20:19
Bloodyaugust
Bloodyaugust approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@Bloodyaugust Bloodyaugust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

package.json Outdated Show resolved Hide resolved
styleguide/cypress/integration/styleguide-spec.js Outdated Show resolved Hide resolved
styleguide/webpack.config.js Show resolved Hide resolved
juanca
juanca commented Oct 22, 2021
View reviewed changes
styleguide/content/icons/index.js
@@ -1,10 +1,8 @@
/* eslint-disable import/no-commonjs */

const path = require('path');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can no longer use NodeJS packages in the browser. It was easy to switch to string manipulation instead.

@juanca juanca mentioned this pull request Oct 22, 2021
Merged
@juanca
Copy link
Contributor Author

juanca commented Jan 27, 2022

Finally got react-styleguidist to work. Now I need to figure out some memory leaks during production asset compilation in bigmaven...

@juanca juanca marked this pull request as draft February 28, 2022 17:36
@juanca
Copy link
Contributor Author

juanca commented Aug 16, 2022

Repo is moved into bigmaven. Closing.

@juanca juanca closed this Aug 16, 2022
@juanca juanca deleted the webpack_5 branch August 16, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bloodyaugust Bloodyaugust Bloodyaugust approved these changes

Assignees

@juanca juanca

Labels
refactor No change in behavior--just in design or readability site
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanca @Bloodyaugust