Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Language Selection for Review #354

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RuslanAsadov
Copy link

Hi! 👋

I really enjoyed this project, but I noticed that feedback is currently provided only in the default language (English). For open-source projects with global contributors, the ability to receive feedback in multiple languages would make the tool more accessible and streamline the review process for developers whose primary language is not English.

This Pull Request adds the option to specify the language for feedback. Users can now set the --translateLanguage parameter in the configuration to receive feedback in their preferred language, such as Spanish, French, German, etc. The default remains English, so existing users don’t need to change their configurations.

Key Changes:

  • Added the --translateLanguage parameter to the code review configuration file.
  • Updated the documentation with instructions for selecting the feedback language.
  • Adjusted tests accordingly.

I hope this enhancement supports the project’s mission to create accessible and effective code reviews. Looking forward to your feedback and any suggestions to improve this feature!

Thank you very much for your time and consideration! 😊

@mattzcarey
Copy link
Owner

Hey,

Thanks so much for contribution. This is a great idea.

I would prefer if the name for this flag was just language or reviewLanguage. translateLanguage gives me different connotations.

If you make these changes I will merge. I'm on holiday next week so it will be the week after.

Best,
Matt

@RuslanAsadov
Copy link
Author

RuslanAsadov commented Oct 31, 2024

@mattzcarey Hi! Thanks for the comment, I’m really glad you liked it!

I thought that naming the flag simply language might be a bit confusing because it could be mistaken for the main programming language, so I decided to name it more specifically—reviewLanguage.

I’ve made the changes 👍

@RuslanAsadov RuslanAsadov force-pushed the feature/translation-support branch from 761a38d to 99daf98 Compare November 6, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants