Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proxy deploy #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

ShamirSecret
Copy link

What 💻

  • Added functionality to choose between proxy deployment and direct deployment
  • Updated the deploy script to support proxy deployment
  • Improved documentation to include instructions for deploying with or without a proxy

Why ✋

  • To provide users with the flexibility to deploy contracts directly or through a proxy, enhancing the contract's upgradability and manageability.
  • Proxy deployment was added to the deploy script to allow for more advanced deployment scenarios, which are common in production environments.
  • Documentation was updated to ensure users are well informed on how to utilize the new deployment options, promoting best practices and easing the adoption process.

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended.

  • Console output showing successful deployment directly and through a proxy.
  • Updated documentation sections with clear instructions and examples.

Notes 📝

  • The deploy function now accepts a useProxy boolean parameter. Set it to true to enable proxy deployment. The default behavior remains direct deployment if the parameter is not specified or is set to false.
  • Please review the changes in the deploy script closely, especially the handling of constructor arguments for proxy deployments.
  • Future enhancements could include automated decision-making for deployment methods based on contract size or complexity.

@ShamirSecret ShamirSecret requested a review from a team as a code owner March 21, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant