Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fees transactions order in mempool #492

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: fees transactions order in mempool #492

wants to merge 10 commits into from

Conversation

Romsters
Copy link
Contributor

@Romsters Romsters commented Dec 14, 2024 •
edited
Loading

What 💻

  • Added CLI param --order for transactions order in mempool.
  • Added fees transactions order option, sorts transactions by max_fee_per_gas.
  • FIFO is still the default option to reflect mainnet.

Why ✋

Feature parity with anvil.

@Romsters Romsters marked this pull request as ready for review December 17, 2024 16:22
@Romsters Romsters requested a review from a team as a code owner December 17, 2024 16:22
dutterbutter
dutterbutter reviewed Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the nit with naming convention

crates/cli/src/cli.rs Outdated Show resolved Hide resolved
crates/config/src/config.rs Outdated Show resolved Hide resolved
crates/cli/src/main.rs Outdated Show resolved Hide resolved
crates/config/src/config.rs Outdated Show resolved Hide resolved
crates/config/src/config.rs Outdated Show resolved Hide resolved
crates/core/src/node/in_memory.rs Outdated Show resolved Hide resolved
crates/core/src/node/pool.rs Outdated Show resolved Hide resolved
crates/core/src/node/pool.rs Outdated Show resolved Hide resolved
crates/core/src/node/pool.rs Outdated Show resolved Hide resolved
crates/core/src/node/pool.rs Outdated Show resolved Hide resolved
dutterbutter
dutterbutter previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Romsters
Copy link
Contributor Author

Closes #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter left review comments

@itegulov itegulov Awaiting requested review from itegulov

@popzxc popzxc Awaiting requested review from popzxc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Romsters @dutterbutter