Fix hot reload min/max change breaking sliders #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix hot reload min/max change breaking slider
Problem
if you change the min or max values with a hot reload the slider beaks
The slider will still think the initial min and max variables are the current once even after changing them.
This causes the following problems:
My solution
Change it so that useInstance only sets a percentage with out knowing the min and max value.
This fixes both problems put above.
This means that I changed the value state to a percentage state and calculate the value every frame.
Changed behaver
This fix changes the behaver of the slider once the values are changed.
Before value stayed the same even if the min and max changed
After now the percentage will stay the same meaning the value changes if min and max are changed