Update ci.yml

[aressu1985]

PR Type

enhancement, configuration changes

---

Description

• Updated the CI workflow to use the matrixorigin/CI/actions/setup-env@main action for setting up the environment instead of a local path.
• Removed the step for setting up JDK 8, simplifying the CI configuration.

---

Changes walkthrough 📝

	Relevant files
Configuration changes	ci.yml Update CI workflow to use external setup action and remove JDK setup .github/workflows/ci.yml Changed the setup action for environment from a local path to a repository reference. Removed the setup step for JDK 8. +2/-9

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and limited to the CI configuration file. The modifications involve updating an action used in the workflow and removing an unnecessary JDK setup step. These changes are not complex and can be reviewed relatively quickly.
🧪 Relevant tests	No
⚡ Possible issues	No
🔒 Security concerns	No

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Verify the new action to ensure it correctly sets up the environment The new action matrixorigin/CI/actions/setup-env@main should be verified to ensure it is correctly setting up the environment as expected. If it is a custom action, make sure it is well-documented and maintained. .github/workflows/ci.yml [63-64] +- name: Set up ENV + uses: matrixorigin/CI/actions/setup-env@main - Suggestion importance[1-10]: 7 Why: This suggestion is relevant as it addresses the introduction of a new GitHub action, ensuring it functions as intended, which is crucial for maintaining CI stability.	7
	Verify that removing the JDK setup step does not impact downstream jobs Ensure that the removal of the JDK setup step does not affect any downstream jobs or steps that might depend on Java being available in the environment. .github/workflows/ci.yml [84-86] +- name: Set up JDK 8 for x64 + uses: actions/setup-java@v3 + with: + java-version: '8' + distribution: 'adopt' + architecture: x64 - Suggestion importance[1-10]: 7 Why: This suggestion is important as it addresses potential dependencies on the JDK setup that was removed, which could affect subsequent steps or jobs if not handled properly.	7
Best practice	Add a step to verify the environment setup Consider adding a step to verify the environment setup by running a simple command or script to ensure that all necessary environment variables and dependencies are correctly configured. .github/workflows/ci.yml [63-64] - name: Set up ENV uses: matrixorigin/CI/actions/setup-env@main +- name: Verify ENV Setup + run: echo "Environment setup verification" + Suggestion importance[1-10]: 7 Why: Adding a verification step after setting up the environment is a good practice to ensure that the setup was successful, enhancing the robustness of the CI process.	7
	Pin the action to a specific commit SHA for reproducibility If the setup-env action is not widely used or tested, consider pinning the action to a specific commit SHA to ensure reproducibility and avoid potential issues with future changes. .github/workflows/ci.yml [63-64] - name: Set up ENV - uses: matrixorigin/CI/actions/setup-env@main + uses: matrixorigin/CI/actions/setup-env@<commit-sha> Suggestion importance[1-10]: 6 Why: Pinning to a specific commit SHA is a best practice for maintaining consistency and avoiding issues with future changes to the action, though it's less critical than ensuring the action works correctly.	6