-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: strcmp function #18483
Open
leo-livis
wants to merge
13
commits into
matrixorigin:main
Choose a base branch
from
leo-livis:addfunc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0249912
[Feature Request]: strcmp function #15359
livis7 3ae692f
Merge remote-tracking branch 'upstream/main'
livis7 fd484bc
[Feature Request]: strcmp function #15359
livis7 17af231
Merge branch 'main' into addfunc
leo-livis c949329
Merge branch 'main' into addfunc
leo-livis 745ed4f
Merge branch 'main' into addfunc
leo-livis bee0648
Merge branch 'main' into addfunc
leo-livis bf169ee
Merge branch 'main' into addfunc
leo-livis adbe40e
Merge branch 'main' into addfunc
leo-livis c70aa8b
Merge branch 'main' into addfunc
leo-livis e7904c7
Merge branch 'main' into addfunc
leo-livis 3cc4b37
Merge branch 'main' into addfunc
leo-livis af1845b
Merge branch 'main' into addfunc
leo-livis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1517,6 +1517,27 @@ var supportedStringBuiltIns = []FuncNew{ | |
}, | ||
}, | ||
|
||
// function `strcmp` | ||
{ | ||
functionId: STRCMP, | ||
class: plan.Function_STRICT, | ||
layout: STANDARD_FUNCTION, | ||
checkFn: fixedTypeMatch, | ||
|
||
Overloads: []overload{ | ||
{ | ||
overloadId: 0, | ||
args: []types.T{types.T_varchar, types.T_varchar}, | ||
retType: func(parameters []types.Type) types.Type { | ||
return types.T_int32.ToType() | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. int32 here. |
||
newOp: func() executeLogicOfOverload { | ||
return Strcmp | ||
}, | ||
}, | ||
}, | ||
}, | ||
|
||
// function `prefix_eq` | ||
{ | ||
functionId: PREFIX_EQ, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why use int8 instead of int32? the function signature said int32.