Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: upgrade go version to 1.21.5 #13973

Merged
merged 7 commits into from
Jan 8, 2024
Merged

CI: upgrade go version to 1.21.5 #13973

merged 7 commits into from
Jan 8, 2024

Conversation

guguducken
Copy link
Contributor

@guguducken guguducken commented Jan 3, 2024 •
edited by sukki37
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #

What this PR does / why we need it:

also upgrade golangci-lint, but it report this error
image
open issue: #13983

@guguducken guguducken requested a review from sukki37 as a code owner January 3, 2024 08:24
@mergify mergify bot added the kind/test-ci label Jan 3, 2024
@guguducken guguducken marked this pull request as draft January 3, 2024 08:41
@guguducken guguducken marked this pull request as ready for review January 8, 2024 02:41
@guguducken
Copy link
Contributor Author

bug fixed, @sukki37 @zhangxu19830126 PTAL

@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Jan 8, 2024
@mergify mergify bot merged commit 594ad8b into matrixorigin:main Jan 8, 2024
23 checks passed
@guguducken guguducken deleted the upgrade_go_version branch January 8, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukki37 sukki37 sukki37 approved these changes

@zhangxu19830126 zhangxu19830126 zhangxu19830126 approved these changes

Assignees
No one assigned
Labels
kind/test-ci size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guguducken @zhangxu19830126 @sukki37 @matrix-meow