Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for room dir search #735

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Tests for room dir search #735

merged 3 commits into from
Oct 31, 2019

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston requested a review from a team October 29, 2019 10:46
richvdh
richvdh reviewed Oct 29, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the directory updated asynchronously? and won't this fail on workers?

you probably need to wrap the /publicRooms request in a loop?

@erikjohnston erikjohnston requested review from richvdh and a team October 29, 2019 11:26
@erikjohnston
Copy link
Member Author

Good point, should be fixed now

@richvdh richvdh changed the title Tests room dir search Tests for room dir search Oct 29, 2019
richvdh
richvdh requested changes Oct 29, 2019
View reviewed changes
tests/30rooms/70publicroomslist.pl Outdated Show resolved Hide resolved
tests/30rooms/70publicroomslist.pl Outdated Show resolved Hide resolved
@erikjohnston erikjohnston requested a review from richvdh October 31, 2019 14:32
richvdh
richvdh approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit 43795c1 into develop Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @richvdh