Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable testing of log contexts for synapse #722

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Enable testing of log contexts for synapse #722

merged 1 commit into from
Oct 10, 2019

Conversation

erikjohnston
Copy link
Member

Flag was added in matrix-org/synapse#6127

@erikjohnston erikjohnston requested a review from a team October 10, 2019 12:31
richvdh
richvdh reviewed Oct 10, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm I think, though I am wary of it slowing things down excessively. does it make much difference to the run times? Maybe we should just do this for a subset of the runs?

@erikjohnston
Copy link
Member Author

Looking across some builds it doesn't seem to have slowed things down, most of the differences look like normal variance.

@erikjohnston erikjohnston merged commit 06a35bf into develop Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @richvdh