Starting with apt 1.6, https support has moved into the main package … #7801
Conversation
…and apt-transport-https has become a transitional dummy package.
| ``` | ||
|
|
||
| for Debian/Ubuntu versions shipping `apt` < 1.6 (Debian < 10 / Ubuntu < 18.04), or | ||
|
|
||
| ``` | ||
| sudo apt install -y lsb-release wget | ||
| ``` | ||
|
|
||
| for Debian 10 / Ubuntu 18.04 and newer, followed by | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Hrm. I am unconvinced by this.
My concern is that it makes things much more complicated for users to understand what to do. It used to be a single set of commands that people could follow; now they have to read carefully to understand exactly which commands they have to run.
People are terrible at reading.
At the very least, I'd prefer sudo apt install -y apt-transport-https to be an additional step which you have to apply for older systems, but why is it a problem if the apt-transport-https package is installed on distros where it is a dummy package?
There was a problem hiding this comment.
Why install useless packages?
There was a problem hiding this comment.
I thought I explained that. Because it's much easier to say to a user "here, follow this one set of instructions" than "check your apt version and then copy some bits from here, and some other bits from over there".
There was a problem hiding this comment.
And then he finds out it's a dummy and deinstalls it again...
Anyway, I'll reword the text...
There was a problem hiding this comment.
And then he finds out it's a dummy and deinstalls it again...
well, that's no problem. If the user is smart enough to do that, they are welcome to.
I do see your point, I just think https://github.com/matrix-org/synapse/blob/2362441544b0dd510cae9321c34e76aca3ad9965/INSTALL.md#matrixorg-packages is an order of magnitude harder to understand than https://github.com/matrix-org/synapse/blob/91a7c5ff6d3a4bc30d61da96e4923d391c6d2ed9/INSTALL.md#matrixorg-packages, and people already find our installation instructions scary.
I think I'm going to revert this for now; if you'd like to suggest improvements, feel free to make a separate PR (or better yet, join #synapse-dev:matrix.org to discuss).
This reverts commit e0c0129. As discussed at #7801 (review), I don't think this is an improvement.
…anoa/amorgan.xyz * 'release-v1.17.0' of github.com:matrix-org/synapse: (117 commits) 1.17.0 update changelog fix migration, again fix changelog 1.16.1 Drop incorrectly-added table `local_rejections_stream`. (#7816) 1.17.0rc1 Fix some spelling mistakes / typos. (#7811) `update_membership` declaration: now always returns an event id. (#7809) Improve stacktraces from exceptions in background processes (#7808) Fix `can only concatenate list (not "tuple") to list` exception (#7810) Pass original request headers from workers to the main process. (#7797) Generate real events when we reject invites (#7804) Add `HomeServer.signing_key` property (#7805) Revert "Update the installation docs on apt-transport-https (#7801)" Do not use simplejson in Synapse. (#7800) Stop passing bytes when dumping JSON (#7799) Update the installation docs on apt-transport-https (#7801) shuffle changelog slightly 1.16.0 ...
* commit '43726783e': (22 commits) 1.17.0rc1 Fix some spelling mistakes / typos. (#7811) `update_membership` declaration: now always returns an event id. (#7809) Improve stacktraces from exceptions in background processes (#7808) Fix `can only concatenate list (not "tuple") to list` exception (#7810) Pass original request headers from workers to the main process. (#7797) Generate real events when we reject invites (#7804) Add `HomeServer.signing_key` property (#7805) Revert "Update the installation docs on apt-transport-https (#7801)" Do not use simplejson in Synapse. (#7800) Stop passing bytes when dumping JSON (#7799) Update the installation docs on apt-transport-https (#7801) shuffle changelog slightly Change Caddy links (old is deprecated) (#7789) Stop populating unused table `local_invites`. (#7793) Refactor getting replication updates from database v2. (#7740) Add libwebp dependency to Dockerfile (#7791) Add documentation for JWT login type and improve sample config. (#7776) Convert the appservice handler to async/await. (#7775) Don't ignore `set_tweak` actions with no explicit `value`. (#7766) ...
…and apt-transport-https has become a transitional dummy package.
Signed-off-by: Dirk Heinrichs [email protected]