add org.matrix.login.jwt so that m.login.jwt can be deprecated #7675
Conversation
|
Also related: matrix-org/matrix-spec-proposals#2416 |
There was a problem hiding this comment.
Hi Soru, thanks for raising this.
We've discussed as a team what to do here. We agree that it's not good that Synapse is implementing login methods in the m. namespace without them being specced, but we don't think we can land this as it currently stands because we're pretty sure that at least a couple of users are (somehow) using it and it wouldn't be fair on them to break it without warning.
Instead, we think it would make sense to deprecate Synapse's implementation of m.login.jwt, with the intention of disabling it in the future and replacing it with org.matrix.login.jwt. In the meantime, we should allow both login methods to give users a chance to transition. (In the past, when we've deprecated things, we've allowed a couple of releases after the announcement before removing them.)
So, do you think you could modify this PR to support both login methods? We would be happy to land such a PR and would put a deprecation notice out in the next release.
richvdh
added
the
X-Awaiting-Changes
|
Done |
|
Done! |
richvdh
removed
the
X-Awaiting-Changes
richvdh
changed the title
* commit 'dc80a0762': 1.16.0rc1 Back out MSC2625 implementation (#7761) Additional configuration options for auto-join rooms (#7763) Add some metrics for inbound and outbound federation processing times (#7755) Explain the purpose of the "tests" conditional dependency requirement (#7751) Add another yield point to state res v2 (#7746) Move flake8 to end. Don't exit script on failure (#7738) Make tox actions work on Debian 10 (#7703) Yield during large v2 state res. (#7735) add org.matrix.login.jwt so that m.login.jwt can be deprecated (#7675) Set Content-Length for Metrics requests (#7730) Sync ignored table names in synapse_port_db to current database schema (#7717) Allow local media to be marked as safe from being quarantined. (#7718) Convert directory handler to async/await (#7727) Speed up state res v2 across large state differences. (#7725)
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.m.login.jwtis not part of the spec, and them.namespace is reserved for things in the spec. When soru asked about this a few months ago, the reply was to not use this endpoint and that it might be removed at any point in time, due to not being in the spec. This PR namespaces the endpoint properly.Signed-off-by: Sorunome [email protected]