This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add a background update to clear tombstoned rooms from the directory #6648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/remove_tombstoned_rooms_from_directory
branch
from
44bd19e to
dbcbd60
Compare
erikjohnston
suggested changes
Jan 7, 2020
| return len(rooms) | ||
|
|
||
| def set_room_is_public(self, room_id, is_public): | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
They way we've done this elsewhere is to have RoomBackgroundUpdateStore inherit from a class with this function defined (which is tedious but at least avoids spurious NotImplementedError stuff). You could also use ABC metaclass stuff.
Or we can leave it as is but then I think it needs a comment here as to what on earth is going on
There was a problem hiding this comment.
I've done the ABC thing. perhaps it's better now?
erikjohnston
approved these changes
Jan 7, 2020
richvdh
force-pushed
the
rav/remove_tombstoned_rooms_from_directory
branch
from
8ded2e0 to
a57c7b4
Compare
richvdh
force-pushed
the
rav/remove_tombstoned_rooms_from_directory
branch
from
a57c7b4 to
b55eb5a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6638
Based on #6647