This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Downgrade 'Closing scope' error to a warning to prevent hammering sentry #13552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed an error repeatedly coming up in Sentry after deploying e91a929 to matrix.org yesterday: https://sentry.tools.element.io/organizations/element/issues/725/ (internal link for those with access).
In summary, we're seeing hundreds of thousands of the following on incoming
GET /_matrix/federation/v1/event/{eventId}
requests:@squahtx proposed that this was due to changes in #13489.
This PR reduces the error to a warning so that Sentry data is usable again. We should still separately fix the issue.