This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Clarify the account_validity and email sections of the sample configuration.
#6685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/config_cleanups
branch
from
f97e359 to
f152e34
Compare
make this match the conventions in the rest of the file, and try to document the default behaviour better
Generally try to make this more comprehensible, and make it match the conventions. I've removed the documentation for all the settings which allow you to change the names of the template files, because I can't really see why they are useful.
richvdh
force-pushed
the
rav/config_cleanups
branch
from
f152e34 to
112cfaa
Compare
|
Looks good to me, but don't know if @babolivier wants to have a quick look to make sure that things are fine? |
babolivier
approved these changes
Jan 14, 2020
babolivier
reviewed
Jan 14, 2020
Co-Authored-By: Brendan Abolivier <[email protected]>
|
@babolivier: thanks for catching the inconsistencies here; all good catches. I'm going to take it from your green tick that you're happy with this landing now. |
This was referenced Feb 20, 2020
nim65s
added a commit
to nim65s/oxyta.net
that referenced
this pull request
Apr 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.