Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Rename email.riot_base_url config option #3913

Closed
erikjohnston opened this issue Sep 19, 2018 · 5 comments
Closed

Rename email.riot_base_url config option #3913

erikjohnston opened this issue Sep 19, 2018 · 5 comments
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. Z-Cleanup Things we want to get rid of, but aren't actively causing pain

Comments

@erikjohnston
Copy link
Member

Since it should work with any url link. We probably also want to make it a template, rather than always appending #/room/<room_id>
@neilisfragile neilisfragile added z-p2 (Deprecated Label) enhancement labels Oct 5, 2018
@michaelkaye michaelkaye mentioned this issue Jul 1, 2019
Open
@richvdh richvdh changed the title Rename email_riot_base_url config option Rename email.riot_base_url config option Dec 11, 2019
@vrongmeal
Copy link

Hey! I'm a newbie here. Would like to contribute. Can someone help me with this?

@MadLittleMods MadLittleMods added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Aug 17, 2021
@DMRobertson
Copy link
Contributor

This field has been renamed to client_base_url while maintaining the old name as a fallback:

synapse/synapse/config/emailconfig.py

Lines 289 to 291 in fa71bb1

self.email_riot_base_url = email_config.get(
"client_base_url", email_config.get("riot_base_url", None)
)

The value is not presently a template though.

@DMRobertson DMRobertson added Z-Cleanup Things we want to get rid of, but aren't actively causing pain T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed z-enhancement z-p2 (Deprecated Label) T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Aug 25, 2022
@richvdh
Copy link
Member

richvdh commented Aug 25, 2022

sounds like the original issue is fixed?

@DMRobertson
Copy link
Contributor

I had in mind

We probably also want to make it a template, rather than always appending #/room/<room_id>

for keeping it open. But if we really want this then we can open a new issue.

@DMRobertson
Copy link
Contributor

Closed by #6685.

@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. Z-Cleanup Things we want to get rid of, but aren't actively causing pain
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@neilisfragile @MadLittleMods @richvdh @erikjohnston @DMRobertson @vrongmeal