Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

room state is persisted incorrectly for rejected events #6289

Closed
richvdh opened this issue Oct 30, 2019 · 1 comment
Closed

room state is persisted incorrectly for rejected events #6289

richvdh opened this issue Oct 30, 2019 · 1 comment
Assignees
@richvdh
Labels
z-bug (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Oct 30, 2019

I think we're persisting rejected events with the wrong state_group. Need to investigate a bit more.
@richvdh richvdh self-assigned this Oct 30, 2019
@richvdh richvdh mentioned this issue Oct 30, 2019
Merged
@richvdh richvdh mentioned this issue Nov 4, 2019
Merged
richvdh added a commit that referenced this issue Nov 4, 2019
@richvdh
Fix bug handling rejected events.
a80143f 
Fixes a bug where rejected events were persisted with the wrong state group.

Also fixes an occasional internal-server-error when receiving events over
federation which are rejected and (possibly because they are
backwards-extremities) have no prev_group.

Fixes #6289.
richvdh added a commit that referenced this issue Nov 5, 2019
@richvdh
Fix bug handling rejected events.
a4c9735 
Fixes a bug where rejected events were persisted with the wrong state group.

Also fixes an occasional internal-server-error when receiving events over
federation which are rejected and (possibly because they are
backwards-extremities) have no prev_group.

Fixes #6289.
richvdh added a commit that referenced this issue Nov 6, 2019
@richvdh
Fix bug which caused rejected events to be stored with the wrong room…
807ec3b 
… state (#6320)

Fixes a bug where rejected events were persisted with the wrong state group.

Also fixes an occasional internal-server-error when receiving events over
federation which are rejected and (possibly because they are
backwards-extremities) have no prev_group.

Fixes #6289.
@neilisfragile neilisfragile added z-bug (Deprecated Label) p1 labels Nov 6, 2019
@richvdh
Copy link
Member Author

richvdh commented Nov 7, 2019

fixed by #6320

@richvdh richvdh closed this as completed Nov 7, 2019
@richvdh richvdh mentioned this issue Nov 8, 2019
Merged
@richvdh richvdh mentioned this issue Oct 2, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richvdh richvdh

Labels
z-bug (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neilisfragile @richvdh