This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make room directory search case insensitive #6268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babolivier
approved these changes
Oct 29, 2019
tox.ini
Outdated
| @@ -114,7 +114,7 @@ skip_install = True | |||
| basepython = python3.6 | |||
| deps = | |||
| flake8 | |||
| black | |||
| black==19.3b0 | |||
There was a problem hiding this comment.
Can you add a comment that explains why we're pinning Black to this version?
|
You folks are awesome. I just tested it on macOS desktop on the live riot/matrix.org site... and the search IS now case insensitive. Right on. Enjoy life... eat out more often! |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '1652c8c1f': Add comment as to why we're pinning black in tests Pin black version Newsfile Make room directory search case insensitive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't use
ILIKEbecause sqlite.Fixes #6265