Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

User search is case sensitive in non-latin languages #14630

Closed
babolivier opened this issue Dec 6, 2022 · 0 comments · Fixed by #15143
Closed

User search is case sensitive in non-latin languages #14630

babolivier opened this issue Dec 6, 2022 · 0 comments · Fixed by #15143
Labels
A-User-Directory O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@babolivier
Copy link
Contributor

For example, if a user's display name is ПРИВЕТ (which is "hello" uppercased in Russian), they can only be found by searching with the correct case, whereas searching for привет (same but lowercase) yields no result.

Split out from #13655 (comment)
@babolivier babolivier added A-User-Directory S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 6, 2022
@babolivier babolivier mentioned this issue Dec 6, 2022
Open
@squahtx squahtx mentioned this issue Feb 23, 2023
Merged
squahtx added a commit that referenced this issue Feb 24, 2023
@squahtx
Improve handling of non-ASCII characters in user directory search (#1…
335f52d 
…5143)

* Fix a long-standing bug where non-ASCII characters in search terms,
  including accented letters, would not match characters in a different
  case.
* Fix a long-standing bug where search terms using combining accents
  would not match display names using precomposed accents and vice
  versa.

To fully take effect, the user directory must be rebuilt after this
change.

Fixes #14630.

Signed-off-by: Sean Quah <[email protected]>
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-User-Directory O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve handling of non-ASCII characters in user directory search matrix-org/synapse
2 participants
@babolivier and others