You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
DMRobertson opened this issue
May 11, 2022
· 2 comments
· Fixed by #12723
Assignees
Labels
A-LoggingSynapse's logs (structured or otherwise). Not metrics.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Invalid session for OIDC callback
MacaroonInitException: Must supply serialized macaroon.
File "synapse/handlers/oidc.py", line 220, in handle_oidc_callback
session, state
File "synapse/handlers/oidc.py", line 1186, in verify_oidc_session_token
macaroon = pymacaroons.Macaroon.deserialize(session)
File "pymacaroons/macaroon.py", line 50, in deserialize
'Must supply serialized macaroon.'
Judging from the source code below, it looks like these are errors that we expect to encounter from time to time. Maybe logger.execption -> logger.warning?
This means we won't get tracebacks reported to Sentry.
There are other `logger.exception` and `logger.error` calls in this
file. I tried to only target errors that
- show up a lot in Sentry
- don't sound like our fault
- are still reported to the end-user by other means.
Closes#12707.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-LoggingSynapse's logs (structured or otherwise). Not metrics.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Internal users: https://sentry.matrix.org/sentry/synapse-matrixorg/issues/219508/?query=is%3Aunresolved
First seen in 1.32.2, according to sentry.
Judging from the source code below, it looks like these are errors that we expect to encounter from time to time. Maybe
logger.execption
->logger.warning
?synapse/synapse/handlers/oidc.py
Lines 217 to 229 in 6463244
The text was updated successfully, but these errors were encountered: