Fix push for m.read events

badge_count_last_call was always zero when the response for push notifications included a "rejected" key which mapped to an empty list.
matrix-org · May 16, 2022 · b4e0a3e · b4e0a3e
1 parent 17e1eb7
commit b4e0a3e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/12721.bugfix b/changelog.d/12721.bugfix
@@ -0,0 +1 @@
+Fix push to dismiss notifications when read on another client. Contributed by @SpiritCroc @ Beeper.
diff --git a/synapse/push/httppusher.py b/synapse/push/httppusher.py
@@ -405,7 +405,7 @@ async def dispatch_push(
         rejected = []
         if "rejected" in resp:
             rejected = resp["rejected"]
-        else:
+        if not rejected:
             self.badge_count_last_call = badge
         return rejected
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix push to dismiss notifications when read on another client. Contributed by @SpiritCroc @ Beeper.