Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Upper-bound frozendict dependency (#15114)
Browse files Browse the repository at this point in the history
* Upper-bound frozendict dependency

This is an ugly kludge to solve
#15109. It is not the most
friendly thing to do for downstream packagers (apologies), but we are a)
running low on time at the moment, and b) seeking to remove frozendict
anyway.

* Changelog
  • Loading branch information
David Robertson authored Feb 21, 2023
1 parent bb374f4 commit 8cede52
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions changelog.d/15114.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Upper-bound frozendict dependency. This works around us being unable to test installing our wheels against Python 3.11 in CI.
2 changes: 1 addition & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ python = "^3.7.1"
# we use the TYPE_CHECKER.redefine method added in jsonschema 3.0.0
jsonschema = ">=3.0.0"
# frozendict 2.1.2 is broken on Debian 10: https://github.com/Marco-Sulla/python-frozendict/issues/41
frozendict = ">=1,!=2.1.2"
# We cannot test our wheels against the 2.3.5 release in CI. Putting in an upper bound for this
# because frozendict has been more trouble than it's worth; we would like to move to immutabledict.
frozendict = ">=1,!=2.1.2,<2.3.5"
# We require 2.1.0 or higher for type hints. Previous guard was >= 1.1.0
unpaddedbase64 = ">=2.1.0"
# We require 1.5.0 to work around an issue when running against the C implementation of
Expand Down

1 comment on commit 8cede52

@Marco-Sulla
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me, I found this project for chance.

I want only to say that I removed all the problematic binaries from version 2.1.2, and in 2.3.5 I simply changed the C Extension to optional to support building from sdist. To make it mandatory you have now to put an env variable (documented).

If you contacted me I was very happy to support your project and explain the changes.

That said, immutabledict is a good project so, since you switched to it, I think there's no more to say.

Please sign in to comment.