Migrate existing data to new schema on startup #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
commented
May 3, 2023
kegsay
reviewed
May 9, 2023
added 10 commits
May 9, 2023 18:21
that was easier than expected!
or else we can't enforce non-null user ids in this table
DMRobertson
commented
May 10, 2023
DMRobertson
commented
May 10, 2023
|
|
||
| _, err = txn.Exec(` | ||
| ALTER TABLE syncv3_to_device_ack_pos | ||
| ALTER COLUMN user_id SET NOT NULL, |
There was a problem hiding this comment.
The cleanup for syncv3_to_device_ack_pos above ensures that this ALTER COLUMN succeeds.
DMRobertson
changed the title
(Though idk if we want to keep this around)
DMRobertson
commented
May 10, 2023
cmd/testmigration/main.go
Outdated
There was a problem hiding this comment.
It may be useful to keep this around---this gives us a way to run the migration manually without having to startup the proxy proper.
kegsay
approved these changes
May 10, 2023
added 2 commits
May 12, 2023 12:23
|
I'm going to merge this as it is. I would like to spend a little more time seeing if there are any easy speedups, to minimise downtime. ATM the slowest parts are updating the to_device table. There are occasionally slow /whoami responses too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested sucessfully against an isolated backup of the m.org proxy deployment. (Circa 5 minutes to run and commit.)
I would like to write a few test cases (see #89 (comment)) before closing #89 and #51.