Support refreshing tokens #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
force-pushed
the
dmr/support-refreshing-tokens
branch
from
a430721 to
51f9855
Compare
DMRobertson
force-pushed
the
dmr/support-refreshing-tokens
branch
from
42d05d9 to
4968ed2
Compare
DMRobertson
commented
Apr 27, 2023
DMRobertson
commented
Apr 27, 2023
DMRobertson
commented
Apr 27, 2023
DMRobertson
commented
Apr 27, 2023
Comment on lines
-180
to
-184
|
|
||
| func (s *Storage) UpdateUserIDForDevice(deviceID, userID string) error { | ||
| _, err := s.db.Exec(`UPDATE syncv3_sync2_devices SET user_id = $1 WHERE device_id = $2`, userID, deviceID) | ||
| return err | ||
| } |
There was a problem hiding this comment.
We now need to know the user_id in order to form a device_id; prior to this it was possible that the user id had not yet been fetched from /whoami.
Come to think of it, we could make the user_id column non null here.
There was a problem hiding this comment.
Ahh, it already is null. It's just that sometimes we put the empty string into this column.
There are six entries in this table with user_id = ''. But they all have since = '' too. I think we ought to drop such devices from the table.
DMRobertson
commented
Apr 27, 2023
|
|
||
| // Either: create a brand-new row for this device, or | ||
| // update an existing row for this device with the latest access token. | ||
| // TODO: If the latter, we need to tell any existing poller about the new token. |
There was a problem hiding this comment.
Highlighting this TODO
DMRobertson
commented
Apr 27, 2023
Comment on lines
+170
to
+173
| func (h *Handler) ensureDeviceIDMigrated(d sync2.Device) error { | ||
| if internal.IsNewDeviceID(d.DeviceID) { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Need to write some kind of test for this. E.g.
- manually insert old-style rows into all relevant tables,
- run the migration
- check it succeeds and that we can select the migrated data
kegsay
reviewed
Apr 27, 2023
Comment on lines
-180
to
-184
|
|
||
| func (s *Storage) UpdateUserIDForDevice(deviceID, userID string) error { | ||
| _, err := s.db.Exec(`UPDATE syncv3_sync2_devices SET user_id = $1 WHERE device_id = $2`, userID, deviceID) | ||
| return err | ||
| } |
added 5 commits
April 27, 2023 14:51
|
Closing in favour of newer PRs, #90 for starters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51.
VERY WIP
I am going to force push to this, review at your own peril