Make the docker build trigger on v* tags too.
#341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with the changes in #339 and fixups, this means that releasing is a case of
Proof: I tagged 1e63d8d as v0.99.11-ghatest5. Then https://github.com/matrix-org/sliding-sync/actions/runs/6484915911 ran and https://github.com/matrix-org/sliding-sync/pkgs/container/sliding-sync/136458534?tag=v0.99.11-ghatest5 was published.
This does seem to have marked that version as
latest, which is unfortunate. But I can manually delete that from here once this lands.