Fix race condition in test #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kegsay
added
bug
DMRobertson
reviewed
Oct 11, 2023
DMRobertson
reviewed
Oct 11, 2023
| @@ -31,29 +50,31 @@ func TestDeviceTickerBasic(t *testing.T) { | |||
| DeviceID: "b", | |||
| }) | |||
| time.Sleep(duration * 2) | |||
| if len(payloads) != 1 { | |||
| t.Fatalf("expected 1 callback, got %d", len(payloads)) | |||
| result := payloads.clone() | |||
There was a problem hiding this comment.
Why do we need to clone here, sorry?
There was a problem hiding this comment.
We'd need to lock every time we access the underlying slice, which could then lead to inconsistent results (e.g len=1 when len() is called, but then increases to len=2 later on. It's easier to snapshot the slice.
DMRobertson
approved these changes
Oct 11, 2023
DMRobertson
reviewed
Oct 11, 2023
Comment on lines
+30
to
+34
| func setTimeSinceValue(val time.Duration) { | ||
| timeSinceMu.Lock() | ||
| timeSinceValue = time.Minute * 2 | ||
| timeSinceMu.Unlock() | ||
| } |
There was a problem hiding this comment.
val seems unused here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements half of #243 in a different way which involves less error prone locking.