Fix duplicate leave events #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kegsay
approved these changes
Sep 13, 2023
| res = bob.SlidingSyncUntilMembership(t, res.Pos, inviteRoomID, bob, "leave") | ||
|
|
||
| if room, ok := res.Rooms[inviteRoomID]; ok { | ||
| // If alice is NOT syncing, we run into this failure mode |
There was a problem hiding this comment.
Can you confirm what part of this test was failing without the diff to user.go?
There was a problem hiding this comment.
If Alice is NOT syncing, we receive the leave event twice, once through Accumulate and once through OnLeftRoom.
If Alice IS syncing however, the test fails for exactly the same reason - we receive the same event twice, but at a different place in the test. We're syncing as Bob until we left the room, after that we do another SlidingSync call, which again receives the event.
https://github.com/matrix-org/sliding-sync/actions/runs/6121433636/job/16615233253#step:7:41 was one of the failing tests.
Co-authored-by: kegsay <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still investigating, but doesn't even seem to require multiple pollers as per #250