New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact events in the DB on m.room.redaction #280

Merged

kegsay merged 2 commits into main from kegan/redact

Sep 6, 2023

Member

kegsay commented Aug 31, 2023

Fixes #279


          Redact events in the DB on m.room.redaction

b2c26b7

Fixes #279

kegsay added bug poller labels

kegsay requested a review from DMRobertson

August 31, 2023 16:07

DMRobertson reviewed

View reviewed changes

state/accumulator.go Show resolved Hide resolved

DMRobertson reviewed

View reviewed changes

state/accumulator.go Outdated Show resolved Hide resolved

DMRobertson reviewed

View reviewed changes

state/accumulator.go Show resolved Hide resolved

DMRobertson reviewed

View reviewed changes

state/event_table.go Outdated Show resolved Hide resolved

DMRobertson reviewed

View reviewed changes

state/event_table.go Show resolved Hide resolved

DMRobertson reviewed

View reviewed changes

state/event_table_test.go Show resolved Hide resolved

DMRobertson reviewed

View reviewed changes

Contributor

DMRobertson left a comment

Looks good. I was expecting that we would have to do some kind of cache invalidation---redacting in-memory copies of events in the global and user caches. Why haven't we done that---do we not keep raw event JSON in memory?

Member Author

kegsay commented Sep 5, 2023

No we don't. There is still a cache invalidation problem for calculated information like the room name, but I will address that in another PR.


          Review comments

001e760

kegsay merged commit f53246d into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels